BUG: bug in sort for grouping with a categorical columns (GH8868) #9480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
changed the title
|
well you would need tests. Not sure this 'hack' is correct. |
|
@cottrell ok, other PR is merged in. Pls add tests and update. See if it can be done more naturally. |
cottrell
force-pushed
the
more_groupby_sort
branch
from
d6bf0c7 to
e6aa8f7
Compare
cottrell
force-pushed
the
more_groupby_sort
branch
from
e6aa8f7 to
5a4dafb
Compare
jreback
added a commit
that referenced
this pull request
Feb 18, 2015
BUG: bug in sort for grouping with a categorical columns (GH8868)
|
@cottrell thanks (this was correct) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8868
hack. I can add tests if this passes the CI and we think this should be taken further.